feat: Binding url citation metadata for event#1105
feat: Binding url citation metadata for event#1105flex-myeonghyeon wants to merge 3 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
As a point of reference: in Python, the citation metadata is kept at the level of the equivalent Wouldn't that be a better place for holding the citation metadata information? |
|
@glaforge Regarding your question, I believe you were asking about adding the property to the Event class. Since the Event class already contains groundingMetadata, I thought citationMetadata belonged at the same level of information and added it there as well: Do you think it should only be added to LlmResponse? If so, I will remove it from the Event class. Please let me know your thoughts. |
|
@flex-myeonghyeon Hmmm... That's interesting... I'm also curious: what lead you to this pull request? When/how did you need the citation metadata? What was the use case? |
|
@glaforge When the GoogleSearchAgentTool is used in an ADK response, I wanted to be able to verify the search information that was referenced. My primary goal is to validate the basis of the response, but I also intend to pass this as citation information to the client if needed. While I noticed that the Event class already provides groundingMetadata, I realized that it was missing citationMetadata. That is why I decided to add it. |
Summary
Test plan
🤖 Generated with Claude Code
이 작업을 진행하는데 사용된 프롬프트